GameGrin Gaming Forums
Home LANs Forums Reviews Previews

Go Back   GameGrin Gaming Forums > All Things GameGrin (GG) > Web Site: Updates & Problems

Web Site: Updates & Problems Noticed a problem with the GameGrin site or unsure how to use a feature? Post in here for more information.

Reply
 
Thread Tools Search this Thread Display Modes
Old 12-08-2009, 07:33 AM   #1
djdawsonuk

Bullsquid
Administrator
 
djdawsonuk's Avatar
 
Join Date: Jan 2007
Location: West Midlands, UK
Posts: 4,553
djdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond repute
New Design Live

Please use this thread to help me keep track of any changes or faults you find.

Thanks
__________________
djdawsonuk is online now   Reply With Quote
Old 12-08-2009, 07:52 AM   #2
Platinum
raggggggggge
 
Platinum's Avatar
 
Join Date: Jan 2004
Location: USS Enterprise E
Posts: 31,753
Platinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond repute
Re: New Design Live

Looks much better, tidier, not sure about the 2 coloums next to each other on the right but I am sure I will get used to it.
Good work mate
__________________


"Left cex. Am up on high street
Going to cash gen opposite primark. Then into game in the bridges." - djd4ws0n 2017
Platinum is offline   Reply With Quote
Old 12-08-2009, 07:53 AM   #3
Platinum
raggggggggge
 
Platinum's Avatar
 
Join Date: Jan 2004
Location: USS Enterprise E
Posts: 31,753
Platinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond repute
Re: New Design Live

Spotted a issue!

About half way down the right it says :

Coming Events
No upcoming events.

But theres the banner above it to say there is a lan lol

Edit also Gallery page still appears to be on old design, all the other pages look ok but cnat have a proper look till later, got work
__________________


"Left cex. Am up on high street
Going to cash gen opposite primark. Then into game in the bridges." - djd4ws0n 2017
Platinum is offline   Reply With Quote
Old 12-08-2009, 08:27 AM   #4
Blak

Human Grunt
 
Blak's Avatar
 
Join Date: May 2006
Location: London
Posts: 2,046
Blak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond repute
Re: New Design Live

Figured I'd better put the problems in this thread rather than the other...


Some things:

Oh hell, this really should be fixed otherwise we'll disapear from search engine results
- Previews in the navbar goes to a 404 page
- Most things in the Navigation block (in the middle column below search) don't work, they all go to 404 pages aswell.
- The Breadcrumb trail for most things doesn't work (e.g. On http://www.gamegrin.com/games/review...iginal-trilogy Game, PSP and Review all go to 404 pages)
- Hackable URLs don't work (e.g. http://www.gamegrin.com/games/review/psp/ goes to a 404 page instead of listing all reviews for the psp. Same goes for http://www.gamegrin.com/games/review/ and http://www.gamegrin.com/games/). This one isn't a huge fuckup regarding SEO but it worked in the previous site.

Standards / Semantics / Accessibility
- The GameOn logo at the top left should be a hyperlink to go to the homepage
- Heading Tags! Or more specifically: we haven't got any. The Article Headings (div.title) should be a h1 tag to give them it an extra boost SEO boost. Article titles in the search results should be in h3s.
- If I turn images off I can't read anything as it's black text on a very dark blue background (Quick fix seems to be give #contentWrapper a background color, except that element isn't cleared properly)
- On reviews the scores images (9 / 10 etc) should have an alt tag - If i'm visually impaired and use a screen reader / turn images off I can't see the scores.
- I should be able to move between the moving images in the header. Say I wanted to click on the Left 4 Dead banner but it's just changed to the mag pimping image, at the moment I've got to wait however many seconds (about 8 seconds per image and there's 2 other images atm, so that's 16 seconds total) before the l4d link appears there again.
- Validation! There's 2 elements with the id of sidebar, the slideshow ul needs to have <li>s in it not <ul><a href="/">blah</a><a href="/">blah2</a></ul>, Loads of images need alt tags (admittedly this is jumping through hoops for some things but put alt="" to keep the validator happy), some &s in the youtube videos block need to be escaped to &amp;
- <br clear="all"> is the wrong way to go about clearing things. Use clearfix or overflow:auto; on the parent element instead.

Petty and niche but easy to fix
- Search result items lists: is there any reason why we're using the icon for page add (with the little plus sign) instead of just regular page (sans the plus).
- (Admin only) Shouldn't the View / Edit tabs on an article sit right at the top above the heading rather than right at the end?
- (Opera 9 only) I've got a big block (~140px) of whitespace below the LAN #78 ad on the right hand side, this might be related to the 2 empty a tags that sit around in that drupal block.



Grab me on MSN this afternoon (after about 3ish) Rasher and we'll look at views stuff which should unfuck the first batch of problems at least.
__________________
(Trep) your gonna get buttraped // (Blak) thats your answer to everything // (Trep) true, i like teh rape

Last edited by Blak; 12-08-2009 at 08:34 AM.
Blak is offline   Reply With Quote
Old 12-08-2009, 12:46 PM   #5
Platinum
raggggggggge
 
Platinum's Avatar
 
Join Date: Jan 2004
Location: USS Enterprise E
Posts: 31,753
Platinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond reputePlatinum has a reputation beyond repute
Re: New Design Live

Also the mylan pages are still on the old old site layout
__________________


"Left cex. Am up on high street
Going to cash gen opposite primark. Then into game in the bridges." - djd4ws0n 2017
Platinum is offline   Reply With Quote
Old 12-08-2009, 02:13 PM   #6
JK Ferret

Human Grunt
 
JK Ferret's Avatar
 
Join Date: Jul 2008
Location: In the Village
Posts: 2,249
JK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond repute
Re: New Design Live

Is the poll title on the right (about the moon landings) supposed to link to MyLAN, event #78?
__________________
Quote:
Originally Posted by Platinum View Post
shaking more than Micheal J Fox sat on a washing machine.
JK Ferret is offline   Reply With Quote
Old 12-08-2009, 07:40 PM   #7
Bobster

Tentacle
 
Bobster's Avatar
 
Join Date: Dec 1999
Location: Dorset
Posts: 14,535
Bobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond repute
Re: New Design Live

Result: 23 errors / 0 warnings

line 41 column 59 - Error: document type does not allow element "div" here; missing one of "object", "ins", "del", "map", "button" start-tag
line 63 column 153 - Error: required attribute "alt" not specified
line 64 column 217 - Error: required attribute "alt" not specified
line 65 column 196 - Error: required attribute "alt" not specified
line 88 column 49 - Error: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag
line 116 column 49 - Error: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag
line 140 column 49 - Error: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag
line 166 column 49 - Error: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag
line 194 column 49 - Error: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag
line 218 column 49 - Error: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag
line 245 column 49 - Error: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag
line 268 column 49 - Error: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag
line 297 column 49 - Error: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag
line 317 column 130 - Error: end tag for "p" omitted, but OMITTAG NO was specified
line 316 column 482 - Info: start tag was here
line 322 column 49 - Error: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag
line 370 column 140 - Error: document type does not allow element "style" here
line 377 column 58 - Error: document type does not allow element "style" here
line 379 column 32 - Error: document type does not allow element "style" here
line 426 column 60 - Error: there is no attribute "target"
line 436 column 30 - Error: there is no attribute "nowrap"
line 525 column 10 - Error: there is no attribute "clear"
line 531 column 86 - Error: required attribute "alt" not specified
line 555 column 90 - Error: required attribute "alt" not specified
__________________
Photography
The opinions expressed in this post are purely that of my own and nothing to do with "GameOn Networking Ltd" unless otherwise stated.
Bobster is offline   Reply With Quote
Old 12-08-2009, 08:32 PM   #8
Bobster

Tentacle
 
Bobster's Avatar
 
Join Date: Dec 1999
Location: Dorset
Posts: 14,535
Bobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond repute
Re: New Design Live

graphics

the blue on the side is too dark and its a waste having a drop shadow on the sides.. (i took a screen shot and adjusted levels to see the shadow)

Header, PNG like GIF is slow at loading and as such shouldnt be used for graphics that are 128kb in size, JPG will load quicker

Info bar at the bottom is too dark, it blends too much with the dark blue sides.. would be better if it was the same blue as the strip that stretches across the top..
__________________
Photography
The opinions expressed in this post are purely that of my own and nothing to do with "GameOn Networking Ltd" unless otherwise stated.
Bobster is offline   Reply With Quote
Old 12-08-2009, 09:53 PM   #9
Blak

Human Grunt
 
Blak's Avatar
 
Join Date: May 2006
Location: London
Posts: 2,046
Blak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond repute
Re: New Design Live

Quote:
Originally Posted by Bobster View Post
Header, PNG like GIF is slow at loading and as such shouldnt be used for graphics that are 128kb in size, JPG will load quicker
A teeny bit misleading as the compression algorithms for JPG / GIF / PNG are all different and there are some cases where PNG / GIF is preferable to JPG and shall result in smaller file sizes and better quality.

But Bob's right in this case, the rotating image file sizes are far too big when saved as PNG-32, 129 + 340 + 258KB is huuuuge. In this case saving as JPGs with a reasonable compression ratio would greatly reduce the file size with no noticable loss in image quality.


Also I've just noticed that the header image uses alpha tranparancy pngs, which don't work in IE6 without some hacking about. And you're not allowed to put a div inside an <a> tag (refereing to #overallTopLogo). Instead you could tell the a tag to display:block and replacethe div with an image tag.
__________________
(Trep) your gonna get buttraped // (Blak) thats your answer to everything // (Trep) true, i like teh rape
Blak is offline   Reply With Quote
Old 12-08-2009, 11:38 PM   #10
TGK

Civil Protection
 
TGK's Avatar
 
Join Date: May 2008
Location: The butt of all jokes, apparently
Posts: 6,100
Blog Entries: 13
TGK has a reputation beyond reputeTGK has a reputation beyond reputeTGK has a reputation beyond reputeTGK has a reputation beyond reputeTGK has a reputation beyond reputeTGK has a reputation beyond reputeTGK has a reputation beyond reputeTGK has a reputation beyond reputeTGK has a reputation beyond reputeTGK has a reputation beyond reputeTGK has a reputation beyond repute
Re: New Design Live

Haven't had too much of a look to spot any major problems, but congratulations to everyone involved. It really does look brilliant and all the hard work that has been put in has finally paid off.

Job well done
__________________
TGK is offline   Reply With Quote
Old 13-08-2009, 08:59 AM   #11
Rasher

Tentacle
Administrator
 
Rasher's Avatar
 
Join Date: Nov 1999
Location: Giraffetastic
Posts: 30,247
Blog Entries: 27
Rasher has a reputation beyond reputeRasher has a reputation beyond reputeRasher has a reputation beyond reputeRasher has a reputation beyond reputeRasher has a reputation beyond reputeRasher has a reputation beyond reputeRasher has a reputation beyond reputeRasher has a reputation beyond reputeRasher has a reputation beyond reputeRasher has a reputation beyond reputeRasher has a reputation beyond repute
Re: New Design Live

Quote:
Originally Posted by Platinum View Post
Looks much better, tidier, not sure about the 2 coloums next to each other on the right but I am sure I will get used to it.
Good work mate
Cheers, yeah loving the new look and feel myself
2 columns take a while to get used to, but they haven't been fully used yet (should be a big tidy up on them being done today)


Quote:
Originally Posted by Platinum View Post
Spotted a issue!

About half way down the right it says :

Coming Events
No upcoming events.

But theres the banner above it to say there is a lan lol
Thats to do with the forum calender (its always been there)
if the event isnt in the forum calender it wont show up
cheers for pointing it out, were try and keep that one filled in

Quote:
Originally Posted by Platinum View Post
Edit also Gallery page still appears to be on old design, all the other pages look ok but cnat have a proper look till later, got work
Afraid the gallery is a separate system (that we have added in to the site)
we are hoping to start on that one after this weekend.

Quote:
Originally Posted by Platinum View Post
Also the mylan pages are still on the old old site layout
MyLAN is going to be a massive job
its not just a re-skin of it that it will require, it needs brand new coding
that one is going to take a little longer, but were going to have a big look/talk about it at the coming LAN with users and staff.

Quote:
Originally Posted by JK Ferret View Post
Is the poll title on the right (about the moon landings) supposed to link to MyLAN, event #78?
Thanks for spotting, fixed

Quote:
Originally Posted by TheGingerKid View Post
Haven't had too much of a look to spot any major problems, but congratulations to everyone involved. It really does look brilliant and all the hard work that has been put in has finally paid off.

Job well done
Thanks man, still more to come.
__________________
Join the staff and users in our chat room

Follow us on Facebook / Twitter
Follow me on Twitter
Rasher is offline   Reply With Quote
Old 13-08-2009, 10:15 PM   #12
djdawsonuk

Bullsquid
Administrator
 
djdawsonuk's Avatar
 
Join Date: Jan 2007
Location: West Midlands, UK
Posts: 4,553
djdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond repute
Re: New Design Live

Quote:
Originally Posted by Platinum View Post
Edit also Gallery page still appears to be on old design, all the other pages look ok but cnat have

a proper look till later, got work
One section at a time, want to make sure the main theme is up to scratch (as per Blaks suggestions) before moving onto

themeing other sections of the site.

Quote:
Originally Posted by Blak View Post
- Previews in the navbar goes to a 404 page
- Most things in the Navigation block (in the middle column below search) don't work, they all go to 404 pages aswell.
- The Breadcrumb trail for most things doesn't work (e.g. On http://www.gamegrin.com/games/review...-star-wars-ii-

the-original-trilogy Game, PSP and Review all go to 404 pages)
Fixed

Quote:
Originally Posted by Blak View Post
- Hackable URLs don't work (e.g. http://www.gamegrin.com/games/review/psp/ goes to a 404 page instead of

listing all reviews for the psp. Same goes for http://www.gamegrin.com/games/review/ and http://www.gamegrin.com/games/).

This one isn't a huge fuckup regarding SEO but it worked in the previous site.
Fixed, and modified slightly, now /games/review/ | /game/review/ | /games/review/psp | /game/review/psp | /game/ | /games/

| should all work, and more will be coming. But in the meantime, the core ones are there

Quote:
Originally Posted by Blak View Post
- The GameOn logo at the top left should be a hyperlink to go to the homepage
Fixed, and the DIV is no longer inside an A tag, more specifically, the element is just an A tag, with the correct ID

applied.

Quote:
Originally Posted by Blak View Post
- Heading Tags! Or more specifically: we haven't got any. The Article Headings (div.title) should be a

h1 tag to give them it an extra boost SEO boost. Article titles in the search results should be in h3s.
H1 tags fixed, H3 tags for search i have a fix for - but as of this post, its NYI.

Quote:
Originally Posted by Blak View Post
- If I turn images off I can't read anything as it's black text on a very dark blue background (Quick

fix seems to be give #contentWrapper a background color, except that element isn't cleared properly)
Massive oversight on my behalf here, element is now cleared properly and contains the correct bacground colour, meaning

text is still readable without.

Quote:
Originally Posted by Blak View Post
- On reviews the scores images (9 / 10 etc) should have an alt tag - If i'm visually impaired and use a

screen reader / turn images off I can't see the scores.
Fixed - alt tags now in place.

Quote:
Originally Posted by Blak View Post
- I should be able to move between the moving images in the header. Say I wanted to click on the Left 4

Dead banner but it's just changed to the mag pimping image, at the moment I've got to wait however many seconds (about 8

seconds per image and there's 2 other images atm, so that's 16 seconds total) before the l4d link appears there again.
WIP - But shouldnt be long before its rectified.

Quote:
Originally Posted by Blak View Post
- Validation! There's 2 elements with the id of sidebar, the slideshow ul needs to have <li>s in it not

<ul><a href="/">blah</a><a href="/">blah2</a></ul>, Loads of images need alt tags (admittedly this is jumping through hoops

for some things but put alt="" to keep the validator happy), some &s in the youtube videos block need to be escaped to

&amp;
- <br clear="all"> is the wrong way to go about clearing things. Use clearfix or overflow:auto; on the parent element

instead.
Fixed, sidebar IDs removed and changed to standard classes. Slideshow UL now has correct LIs inside (total schoolboy error

there)
Regarding images with ALT tags missing - I assume you mean the ones in news posts themselves? If so I'll have to bring this

up with the posters I'll do a sweep for any images from the new layout side of things, and edit their tags.
Rasher told me that you'd fixed the YouTube bar as well, cheers for that.

Quote:
Originally Posted by Blak View Post
- Search result items lists: is there any reason why we're using the icon for page add (with the little

plus sign) instead of just regular page (sans the plus).
Will change the image - minor oversight more than any intended reason

Quote:
Originally Posted by Blak View Post
- (Admin only) Shouldn't the View / Edit tabs on an article sit right at the top above the heading

rather than right at the end?
This was a descicion of page layout (what users see) against additional tabs for admins which drop the layout and

differentiate what we see against standard authenticated users. I had tried them in the sidebar area, but that looked even

worse.

Quote:
Originally Posted by Blak View Post
- (Opera 9 only) I've got a big block (~140px) of whitespace below the LAN #78 ad on the right hand

side, this might be related to the 2 empty a tags that sit around in that drupal block.
Unless you've already fixed it, can you send me a screenshot of this one. And I'll tend to is ASAP.

Quote:
Originally Posted by Platinum View Post
Also the mylan pages are still on the old old site layout
As Rasher has posted, this needs more than just a re-style We'll keep you posted when changes are happening

Quote:
Originally Posted by JK Ferret View Post
Is the poll title on the right (about the moon landings) supposed to link to MyLAN, event #78?
Fixed.

Quote:
Originally Posted by Bobster View Post
the blue on the side is too dark and its a waste having a drop shadow on the sides.. (i took a screen shot and adjusted levels to see the shadow)
Changed.

Quote:
Originally Posted by Bobster View Post
Header, PNG like GIF is slow at loading and as such shouldnt be used for graphics that are 128kb in size, JPG will load quicker
Havn't uploaded the changes yet, but I have the .jpgs ready to go.

Quote:
Originally Posted by Bobster View Post
Info bar at the bottom is too dark, it blends too much with the dark blue sides.. would be better if it was the same blue as the strip that stretches across the top.
I intend to pimp the footer some more, and a change of colour will be one of the things to be done.

Thanks for all the feedback so far, it's quality digging your nails in like this that will make it much better in the long run. So keep looking for it so it can be fixed!
__________________
djdawsonuk is online now   Reply With Quote
Old 14-08-2009, 04:44 AM   #13
JK Ferret

Human Grunt
 
JK Ferret's Avatar
 
Join Date: Jul 2008
Location: In the Village
Posts: 2,249
JK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond reputeJK Ferret has a reputation beyond repute
Re: New Design Live

Rep due Dawson, purely for being able to get away with a post that bloody long, without being Boff (even if half of it is quotes..)
__________________
Quote:
Originally Posted by Platinum View Post
shaking more than Micheal J Fox sat on a washing machine.
JK Ferret is offline   Reply With Quote
Old 14-08-2009, 08:11 AM   #14
evilgiraffeman

Manhack
 
evilgiraffeman's Avatar
 
Join Date: Feb 2008
Location: North East
Posts: 1,155
evilgiraffeman is just really niceevilgiraffeman is just really niceevilgiraffeman is just really niceevilgiraffeman is just really niceevilgiraffeman is just really niceevilgiraffeman is just really niceevilgiraffeman is just really niceevilgiraffeman is just really niceevilgiraffeman is just really niceevilgiraffeman is just really niceevilgiraffeman is just really nice
Re: New Design Live

Hey, clicked on the review and preview tabs just now and there are none listed.

When I access stuff from the main menu it appears just fine however.

http://www.gamegrin.com/game/review
evilgiraffeman is offline   Reply With Quote
Old 14-08-2009, 11:17 AM   #15
POBmaestro

Human Grunt
 
POBmaestro's Avatar
 
Join Date: Nov 2007
Location: The day after yesterday
Posts: 2,547
POBmaestro is a glorious beacon of lightPOBmaestro is a glorious beacon of lightPOBmaestro is a glorious beacon of lightPOBmaestro is a glorious beacon of lightPOBmaestro is a glorious beacon of lightPOBmaestro is a glorious beacon of lightPOBmaestro is a glorious beacon of lightPOBmaestro is a glorious beacon of lightPOBmaestro is a glorious beacon of lightPOBmaestro is a glorious beacon of lightPOBmaestro is a glorious beacon of light
Re: New Design Live

Brilliant work Dawson, the website looks amazing

I had a lot of layout issues with the menus but clearing the cache fixed those. I do second giraffes problem of having no reviews or previews listed though
__________________
_________
___
_
POBmaestro is offline   Reply With Quote
Old 14-08-2009, 03:30 PM   #16
djdawsonuk

Bullsquid
Administrator
 
djdawsonuk's Avatar
 
Join Date: Jan 2007
Location: West Midlands, UK
Posts: 4,553
djdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond repute
Re: New Design Live

Cheers catching the reviews and previews - they are sorted now, and should look a bit sexier as well
__________________
djdawsonuk is online now   Reply With Quote
Old 14-08-2009, 04:59 PM   #17
Blak

Human Grunt
 
Blak's Avatar
 
Join Date: May 2006
Location: London
Posts: 2,046
Blak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond reputeBlak has a reputation beyond repute
Re: New Design Live

Quote:
Originally Posted by djdawsonuk View Post
Quote:
- (Opera 9 only) I've got a big block (~140px) of whitespace below the LAN #78 ad on the right hand side, this might be related to the 2 empty a tags that sit around in that drupal block.
Unless you've already fixed it, can you send me a screenshot of this one. And I'll tend to is ASAP.
This is fixed now.

Quote:
Originally Posted by djdawsonuk View Post
Regarding images with ALT tags missing - I assume you mean the ones in news posts themselves?
I was refering to the rotating images in the header and the 2 footer images (<img src="http://www.gamegrin.com/sites/all/themes/gameon/images/footer_fadeout.png" /> and <img src="http://www.gamegrin.com/sites/all/themes/gameon/images/footer_top.png" />).


Some more picky bits on the validation front:

You can't put a ul inside a span (as ul is a block element and spans are inline), where the read more / comments bit is under each post on the homepage '<div class="node-bottom"><span class="submitted"><ul class="links inline">'. As the span doesn't appear to be styled to do anything you could just get rid of it and have '<div class="node-bottom"><ul class="links inline">....'

The last image on the page (that calls cron.php): border isn't a valid attribute in XHTML strict and the image needs to sit inside a block level element, move it up 2 lines and stick it inside #footerfade or wrap it in a div (or if it's not particularly useful get rid of it.)

You've got a <br clear="all" />, clear isn't a valid attribute in XHTML Strict and as I've mentioned before this is a crappy way of clearing elements (the better way is to use clearfix, which boils down to adding a class called .clearfix then applying it to the container element rather than adding an extra html element.


There's also a <td nowrap="nowrap"> which appears in the poll block and an a tag with target="_blank" in the lan pimping block on the right hand side and once again these attributes aren't valid XHTML Strict attributes. Either get rid of them or drop the DOCTYPE down to XHTML Transitional. TBH I'm not exactly convinced on the usefulness of the latest poll block in the first place but getting rid of that is a decision for Rasher.
__________________
(Trep) your gonna get buttraped // (Blak) thats your answer to everything // (Trep) true, i like teh rape
Blak is offline   Reply With Quote
Old 14-08-2009, 05:50 PM   #18
djdawsonuk

Bullsquid
Administrator
 
djdawsonuk's Avatar
 
Join Date: Jan 2007
Location: West Midlands, UK
Posts: 4,553
djdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond repute
Re: New Design Live

Quote:
Originally Posted by Blak View Post
I was refering to the rotating images in the header and the 2 footer images (<img src="http://www.gamegrin.com/sites/all/themes/gameon/images/footer_fadeout.png" /> and <img src="http://www.gamegrin.com/sites/all/themes/gameon/images/footer_top.png" />).
These are now done.

Quote:
Originally Posted by Blak View Post
You can't put a ul inside a span (as ul is a block element and spans are inline), where the read more / comments bit is under each post on the homepage '<div class="node-bottom"><span class="submitted"><ul class="links inline">'. As the span doesn't appear to be styled to do anything you could just get rid of it and have '<div class="node-bottom"><ul class="links inline">....'
Updated

Quote:
Originally Posted by Blak View Post
The last image on the page (that calls cron.php): border isn't a valid attribute in XHTML strict and the image needs to sit inside a block level element, move it up 2 lines and stick it inside #footerfade or wrap it in a div (or if it's not particularly useful get rid of it.)
This isn't part of the theme code, and I can't see any reference to images past "footer_fadeout" using firebug - where did you find this? If possible can you grab a screen shot of the offending code and post it here.

Quote:
Originally Posted by Blak View Post
You've got a <br clear="all" />, clear isn't a valid attribute in XHTML Strict and as I've mentioned before this is a crappy way of clearing elements (the better way is to use clearfix, which boils down to adding a class called .clearfix then applying it to the container element rather than adding an extra html element.
Now cleared correctly - There were two instances of the BR clearing method in there. I had removed one previously, and missed the other.


Quote:
Originally Posted by Blak View Post
There's also a <td nowrap="nowrap"> which appears in the poll block
Poll block is generated by the vbDrupal linkup. Will look for fixes.

Quote:
Originally Posted by Blak View Post
and an a tag with target="_blank" in the lan pimping block on the right hand side and once again these attributes aren't valid XHTML Strict attributes. Either get rid of them or drop the DOCTYPE down to XHTML Transitional.
Changed
__________________
djdawsonuk is online now   Reply With Quote
Old 14-08-2009, 06:15 PM   #19
Bobster

Tentacle
 
Bobster's Avatar
 
Join Date: Dec 1999
Location: Dorset
Posts: 14,535
Bobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond reputeBobster has a reputation beyond repute
Re: New Design Live

looking at the new page, the bevel & emboss on the GameOn could do with being binned and just going for the strong outline and the grad..
__________________
Photography
The opinions expressed in this post are purely that of my own and nothing to do with "GameOn Networking Ltd" unless otherwise stated.
Bobster is offline   Reply With Quote
Old 14-08-2009, 08:54 PM   #20
djdawsonuk

Bullsquid
Administrator
 
djdawsonuk's Avatar
 
Join Date: Jan 2007
Location: West Midlands, UK
Posts: 4,553
djdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond reputedjdawsonuk has a reputation beyond repute
Re: New Design Live

Quote:
Originally Posted by Bobster View Post
looking at the new page, the bevel & emboss on the GameOn could do with being binned and just going for the strong outline and the grad..
Will do a comparison screenshot, and put it up here for critique/feedback.
__________________
djdawsonuk is online now   Reply With Quote
Reply

Bookmarks

Tags
design, live

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Some Web Design Help Rasher General Chat 8 06-11-2001 04:10 PM


All times are GMT +1. The time now is 04:38 PM.


More on gaming

Powered by vBulletin®
Copyright ©2000 - 2018, Jelsoft Enterprises Ltd.
© 2016 GameOn Networking Ltd, T/A GameGrin